LGTM
http://codereview.chromium.org/8510005/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/8510005/diff/1/src/ia32/code-stubs-ia32.cc#newcode5110 src/ia32/code-stubs-ia32.cc:5110: // Put smi-tagged index into scratch register. Remove the comment too. http://codereview.chromium.org/8510005/diff/1/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/8510005/diff/1/src/x64/code-stubs-x64.cc#newcode4125 src/x64/code-stubs-x64.cc:4125: STATIC_ASSERT((kStringEncodingMask & kTwoByteStringTag) == 0); Could we convert index from smi to int32 here, instead of doing it in two places below? http://codereview.chromium.org/8510005/diff/1/test/mjsunit/string-slices.js File test/mjsunit/string-slices.js (right): http://codereview.chromium.org/8510005/diff/1/test/mjsunit/string-slices.js#newcode28 test/mjsunit/string-slices.js:28: // Flags: --string-slices --expose-externalize-string --allow-natives-syntax If string-slices is on by default now, we should remove the flag here. http://codereview.chromium.org/8510005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
