On 2011/11/09 16:10:20, Sven wrote:
http://codereview.chromium.org/8510014/diff/1/Makefile
File Makefile (right):

http://codereview.chromium.org/8510014/diff/1/Makefile#newcode150
Makefile:150: --arch=$(shell echo $(DEFAULT_ARCHES) | sed -e 's/ /,/g') \
No need for sed, use subst:
http://www.gnu.org/s/hello/manual/make/Syntax-of-Functions.html

The space/comma hack required for that is pretty ugly, making me prefer the
shell command.

http://codereview.chromium.org/8510014/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to