LGTM (with nits).
http://codereview.chromium.org/8507038/diff/1/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/8507038/diff/1/src/spaces.cc#newcode758 src/spaces.cc:758: // Adjust list of unswept pages if the page is it's head or tail. This block assumes that last_unswept_page_ is either NULL or refers to the page's anchor. Can we add an assertion checking that? http://codereview.chromium.org/8507038/diff/1/src/spaces.cc#newcode797 src/spaces.cc:797: if (sizes.Total() == Page::kObjectAreaSize) { Currently the free-list count at this point should always sum up to Page::kObjectAreaSize so can we turn this into an assertion instead? This would save us the counting in release builds. http://codereview.chromium.org/8507038/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
