Revision: 9955
Author:   [email protected]
Date:     Thu Nov 10 06:13:32 2011
Log: MIPS: Fixed a bug in StringHelper::GenerateTwoCharacterSymbolTableProbe.

r9871 (5baeaf57) changed the fill value for deleted entries in hash tables from null_value to the_hole_value.
This commit changes an assertion in MIPS code that expects this value.

BUG=
TEST=

Review URL: http://codereview.chromium.org/8479028
Patch from Gergely Kis <[email protected]>.
http://code.google.com/p/v8/source/detail?r=9955

Modified:
 /branches/bleeding_edge/src/mips/code-stubs-mips.cc

=======================================
--- /branches/bleeding_edge/src/mips/code-stubs-mips.cc Thu Nov 10 00:07:39 2011 +++ /branches/bleeding_edge/src/mips/code-stubs-mips.cc Thu Nov 10 06:13:32 2011
@@ -5776,10 +5776,10 @@
     __ Branch(&is_string, ne, scratch, Operand(ODDBALL_TYPE));

     __ Branch(not_found, eq, undefined, Operand(candidate));
-    // Must be null (deleted entry).
+    // Must be the hole value (deleted entry).
     if (FLAG_debug_code) {
-      __ LoadRoot(scratch, Heap::kNullValueRootIndex);
-      __ Assert(eq, "oddball in symbol table is not undefined or null",
+      __ LoadRoot(scratch, Heap::kTheHoleValueRootIndex);
+ __ Assert(eq, "oddball in symbol table is not undefined or the hole value",
           scratch, Operand(candidate));
     }
     __ jmp(&next_probe[i]);

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to