lgtm
http://codereview.chromium.org/8462010/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/8462010/diff/1/src/arm/macro-assembler-arm.cc#newcode1309 src/arm/macro-assembler-arm.cc:1309: // Compute the handler entry address and jump to it. The handler table is Seems this code can be shared between throw and throw uncatchable. http://codereview.chromium.org/8462010/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/8462010/diff/1/src/ia32/macro-assembler-ia32.cc#newcode884 src/ia32/macro-assembler-ia32.cc:884: jmp(edi); Try to share code with Throw(). http://codereview.chromium.org/8462010/diff/1/src/objects.h File src/objects.h (right): http://codereview.chromium.org/8462010/diff/1/src/objects.h#newcode4063 src/objects.h:4063: static const int kHandlerTableOffset = kRelocationInfoOffset + kPointerSize; I think this makes Code's header 64 bytes (with 28 bytes of padding) on ia32. http://codereview.chromium.org/8462010/diff/1/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/8462010/diff/1/src/parser.cc#newcode496 src/parser.cc:496: int NextHandlerIndex() { return next_handler_index_++; } Maybe call it AllocateHandlerIndex()? I would not expect side-effects from function called NextHandlerIndex. http://codereview.chromium.org/8462010/diff/1/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/8462010/diff/1/src/x64/macro-assembler-x64.cc#newcode2577 src/x64/macro-assembler-x64.cc:2577: jmp(rdi); Try to share code with throw. http://codereview.chromium.org/8462010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
