Reviewers: danno, Description: ARM: Check that address given to __ RecordWrite is correct.
Please review this at http://codereview.chromium.org/8511052/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/macro-assembler-arm.cc Index: src/arm/macro-assembler-arm.cc =================================================================== --- src/arm/macro-assembler-arm.cc (revision 9962) +++ src/arm/macro-assembler-arm.cc (working copy) @@ -483,6 +483,15 @@ // registers are cp. ASSERT(!address.is(cp) && !value.is(cp)); + if (FLAG_debug_code) { + Label ok; + ldr(ip, MemOperand(address)); + cmp(ip, value); + b(eq, &ok); + stop("Remembered set pointer is in new space"); + bind(&ok); + } + Label done; if (smi_check == INLINE_SMI_CHECK) { -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
