http://codereview.chromium.org/8518001/diff/1/src/compilation-cache.cc File src/compilation-cache.cc (right):
http://codereview.chromium.org/8518001/diff/1/src/compilation-cache.cc#newcode1 src/compilation-cache.cc:1: // Copyright 2008 the V8 project authors. All rights reserved. On 2011/11/10 11:53:23, Jakob wrote:
2011
Done. http://codereview.chromium.org/8518001/diff/1/src/compilation-cache.h File src/compilation-cache.h (right): http://codereview.chromium.org/8518001/diff/1/src/compilation-cache.h#newcode1 src/compilation-cache.h:1: // Copyright 2008 the V8 project authors. All rights reserved. On 2011/11/10 11:53:23, Jakob wrote:
2011
Done. http://codereview.chromium.org/8518001/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/8518001/diff/1/src/objects.cc#newcode10303 src/objects.cc:10303: FixedArray* pair = FixedArray::cast(other); On 2011/11/10 11:53:23, Jakob wrote:
Please rename this. If it has 4 elements, it's not a pair. Maybe
"array" or
"other_array"?
Done. http://codereview.chromium.org/8518001/diff/1/src/objects.cc#newcode10342 src/objects.cc:10342: FixedArray* pair = FixedArray::cast(obj); On 2011/11/10 11:53:23, Jakob wrote:
Same here
Done. http://codereview.chromium.org/8518001/diff/1/src/objects.cc#newcode10358 src/objects.cc:10358: FixedArray* pair = FixedArray::cast(obj); On 2011/11/10 11:53:23, Jakob wrote:
And here.
Done. http://codereview.chromium.org/8518001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
