First round
http://codereview.chromium.org/8417035/diff/29001/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/8417035/diff/29001/src/arm/full-codegen-arm.cc#newcode2196 src/arm/full-codegen-arm.cc:2196: // Push the receiver of the enclosing function. we still call runtime! http://codereview.chromium.org/8417035/diff/29001/src/arm/full-codegen-arm.cc#newcode2200 src/arm/full-codegen-arm.cc:2200: // Push the language mode. Actually, I also sort of like the existing comment here, it is useful and still true, just change strict mode flat to language mode. http://codereview.chromium.org/8417035/diff/29001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/8417035/diff/29001/src/arm/lithium-codegen-arm.cc#newcode2292 src/arm/lithium-codegen-arm.cc:2292: Handle<Code> ic = (instr->strict_mode_flag() == kStrictMode) Can't we arrive here with extended mode flag? if so, should this be: Handle<Code> ic = (instr->strict_mode_flag() == kNonStrictMode) ? isolate()->builtins()->StoreIC_Initialize() ? isolate()->builtins()->StoreIC_Initialize_Strict(); Same question for several occurrences below http://codereview.chromium.org/8417035/diff/29001/src/compiler.cc File src/compiler.cc (right): http://codereview.chromium.org/8417035/diff/29001/src/compiler.cc#newcode606 src/compiler.cc:606: // After parsing we know function's language mode. Remember it. we know the functions's ... ^ http://codereview.chromium.org/8417035/diff/29001/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): http://codereview.chromium.org/8417035/diff/29001/src/ia32/full-codegen-ia32.cc#newcode2148 src/ia32/full-codegen-ia32.cc:2148: // Push the language mode. same comment as on arm http://codereview.chromium.org/8417035/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
