LGTM
http://codereview.chromium.org/8528024/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): http://codereview.chromium.org/8528024/diff/1/src/profile-generator.cc#newcode2476 src/profile-generator.cc:2476: HandleScope scope; Perhaps better to have this in the loop. As it is now, an unlimited number of handles is ceated (depending on enumerator.count()). It is good that they are destroyed at the end of this function, but it seems even better if they are destroyed at the end of each loop iteration. http://codereview.chromium.org/8528024/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
