On 2011/11/15 18:34:43, Dmitry Lomov (chromium) wrote:
> http://codereview.chromium.org/8536042/diff/1/src/api.cc#newcode534
> src/api.cc:534: reinterpret_cast<int>(entry->value));
> Again, I think it has to be something like
>
static_cast<ExtensionTraversalState>(reintepret_cast<intptr_t>(entry->value)).
cast from void* to int is always ok in C++.
Sorry I take this back. This particular code is ok though, because all
values
that come into entry values come from reinterpret_cast<void*>(int value),
so it
is good. However, I'll change it to intptr_t so as not to raise people's
eyebrows :)
http://codereview.chromium.org/8536042/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
