LGTM
http://codereview.chromium.org/8513016/diff/2001/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/8513016/diff/2001/src/ia32/code-stubs-ia32.cc#newcode5980 src/ia32/code-stubs-ia32.cc:5980: STATIC_ASSERT(kIsIndirectStringMask == (kSlicedStringTag & kConsStringTag)); These two asserts and the following test is a bit hard to follow, please add a comment explaining that if we don't have an indirect string we have either a sequential or an external string (I, at least, had to go to objects.h to convince myself of this) http://codereview.chromium.org/8513016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
