LGTM.
I like the new unit test! Thanks for adding it. I have one improvement so
that
our type feedback guaranteed to be fresh for each test case. Other than
that a
few minor comments.
No need to upload a new version. I'll fix those before committing.
http://codereview.chromium.org/8373029/diff/55031/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
http://codereview.chromium.org/8373029/diff/55031/src/x64/lithium-codegen-x64.cc#newcode1686
src/x64/lithium-codegen-x64.cc:1686:
Remove empty line to fix lint error.
http://codereview.chromium.org/8373029/diff/55031/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):
http://codereview.chromium.org/8373029/diff/55031/src/x64/lithium-x64.cc#newcode1410
src/x64/lithium-x64.cc:1410: return
AssignEnvironment(MarkAsCall(DefineFixed(result, rax), instr));
Remove call to AssignEnvironment.
http://codereview.chromium.org/8373029/diff/63001/test/mjsunit/switch.js
File test/mjsunit/switch.js (right):
http://codereview.chromium.org/8373029/diff/63001/test/mjsunit/switch.js#newcode340
test/mjsunit/switch.js:340:
Global unique id for each generated test case needed:
var test_id = 0;
http://codereview.chromium.org/8373029/diff/63001/test/mjsunit/switch.js#newcode373
test/mjsunit/switch.js:373: 'switch(tag) {' +
Here we need some kind of unique id so that the compilation cache does
not return a previous version of the unoptimized code and spoils our
type feedback:
'"' + (test_id++) + '"; switch(tag) {' +
http://codereview.chromium.org/8373029/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
