LGTM with comments.
http://codereview.chromium.org/8574053/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/8574053/diff/1/src/ia32/code-stubs-ia32.cc#newcode237 src/ia32/code-stubs-ia32.cc:237: FastCloneShallowArrayStub::Mode mode, Just to be explicit, please add an ASSERT(mode != FastCloneShallowArrayStub::CLONE_ANY_ELEMENTS); http://codereview.chromium.org/8574053/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (left): http://codereview.chromium.org/8574053/diff/1/src/ia32/full-codegen-ia32.cc#oldcode1495 src/ia32/full-codegen-ia32.cc:1495: __ IncrementCounter(isolate()->counters()->cow_arrays_created_stub(), 1); This line got lost in the refactoring. Care to put it back in? http://codereview.chromium.org/8574053/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
