LGTM with comments.
http://codereview.chromium.org/8574058/diff/1001/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/8574058/diff/1001/src/ia32/code-stubs-ia32.cc#newcode241 src/ia32/code-stubs-ia32.cc:241: // [esp + kPointerSize]: constant elements. Same as for the x64 version, I don't see why the details of the stack layout are relevant for this method. http://codereview.chromium.org/8574058/diff/1001/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/8574058/diff/1001/src/x64/code-stubs-x64.cc#newcode227 src/x64/code-stubs-x64.cc:227: // Stack layout and register on entry: I don't think the ...Common() method cares about the stack layout. http://codereview.chromium.org/8574058/diff/1001/src/x64/code-stubs-x64.cc#newcode353 src/x64/code-stubs-x64.cc:353: CLONE_DOUBLE_ELEMENTS, &slow_case); s/CLONE_DOUBLE_ELEMENTS/mode/ ! http://codereview.chromium.org/8574058/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
