Status: New
Owner: ----

New issue 1831 by [email protected]: V8 debug shell doesn't compile with gcc 4.6.1
http://code.google.com/p/v8/issues/detail?id=1831

[jwalden@wheres-wally v8]$ scons mode=debug console=readline arch=x64 d8
scons: Reading SConscript files ...
scons: done reading SConscript files.
scons: Building targets ...
g++ -o obj/debug/accessors.o -c -fno-rtti -fno-exceptions -fvisibility=hidden -Wall -Werror -W -Wno-unused-parameter -Wnon-virtual-dtor -pedantic -m64 -g -O0 -ansi -DV8_TARGET_ARCH_X64 -DENABLE_DISASSEMBLER -DDEBUG -DENABLE_DEBUGGER_SUPPORT -DV8_ENABLE_CHECKS -DOBJECT_PRINT -Isrc src/accessors.cc
In file included from src/v8.h:60:0,
                 from src/accessors.cc:28:
src/objects-inl.h: In member function 'void v8::internal::ExternalString::clear_data_cache()': src/objects-inl.h:2301:3: error: converting to non-pointer type 'long int' from NULL [-Werror=conversion-null]
cc1plus: all warnings being treated as errors

scons: *** [obj/debug/accessors.o] Error 1
scons: building terminated because of errors.


The attached diff fixes the problem (by changing a NULL to a 0, in a place where it appears an intptr_t should have been passed), and I'm temporarily using it to build locally. I don't know if it's style-compatible or whatever (this seeming like the sort of thing that might run afoul of such guidelines). Please use it if it's the right way to do it, or adapt it to fit local style as needed.

Attachments:
        v8.diff  354 bytes

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to