LGTM
http://codereview.chromium.org/8595008/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/8595008/diff/1/src/objects.cc#newcode5458 src/objects.cc:5458: result->set(kContentArrayIndex, array, SKIP_WRITE_BARRIER); Do we know that result is in NewSpace? What if it's really big and goes to LOSpace? At least make some asserts to ensure that result really, really only can be in NewSpace. Or comments, if it's obvious when you know it. http://codereview.chromium.org/8595008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
