http://codereview.chromium.org/8590027/diff/1/src/runtime.cc File src/runtime.cc (right):
http://codereview.chromium.org/8590027/diff/1/src/runtime.cc#newcode11247 src/runtime.cc:11247: pre_data = ParserApi::PartialPreParse(source, NULL, flags); Initially this was only for mimicking the behaviour of the initial parse. But indeed we don't have the information anymore if the browser provided preparse data. I can leave it in for speed but also delete it. I rewrote this part, so that it simply does not provide information about stack allocated variables when reparsing fails and refrains from crashing in release mode. On 2011/11/18 14:12:52, Lasse Reichstein wrote:
Why preparse? Is it for speed?
Maybe only do it if the source is larger than 1K, as we do in the
normal
parsing.
http://codereview.chromium.org/8590027/diff/1/test/mjsunit/debug-stepout-scope.js File test/mjsunit/debug-stepout-scope.js (right): http://codereview.chromium.org/8590027/diff/1/test/mjsunit/debug-stepout-scope.js#newcode175 test/mjsunit/debug-stepout-scope.js:175: break invalid_break_label; Moved it to the bugs/ directory. On 2011/11/18 14:12:52, Lasse Reichstein wrote:
Don't add tests like this. It should be an early error, so eventually the preparser will detect
it and the
test will fail. If anything, it should be in the bugs/ directory.
http://codereview.chromium.org/8590027/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
