No, you are right. I will revert that, also in the corresponding spot in the MIPS file.
On Wed, Nov 23, 2011 at 5:58 PM, <[email protected]> wrote: > Drive-by on this one file... > > > > http://codereview.chromium.**org/8680013/diff/1/src/arm/**assembler-arm.h<http://codereview.chromium.org/8680013/diff/1/src/arm/assembler-arm.h> > File src/arm/assembler-arm.h (right): > > http://codereview.chromium.**org/8680013/diff/1/src/arm/** > assembler-arm.h#newcode309<http://codereview.chromium.org/8680013/diff/1/src/arm/assembler-arm.h#newcode309> > src/arm/assembler-arm.h:309: extern const DwVfpRegister& kDoubleRegZero; > disclaimer: I added the reference to remove ~ 40 static initializers. > > I would have thought as it were before, they'd be straight compile time > aliases, but with extern it could need extra relocation records? > > Also not quite clear why an extern reference is better? I think this > would now violate (&kDoubleRegZero == &d14) when used in an arbitrary > .cc, for what that's worth. > > http://codereview.chromium.**org/8680013/<http://codereview.chromium.org/8680013/> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
