LGMT with comments addressed
http://codereview.chromium.org/8682010/diff/1001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/8682010/diff/1001/src/arm/code-stubs-arm.cc#newcode5072 src/arm/code-stubs-arm.cc:5072: masm, object_, index_, result_, &call_runtime_); move masm up and put parameters on individual lines http://codereview.chromium.org/8682010/diff/1001/src/arm/codegen-arm.cc File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/8682010/diff/1001/src/arm/codegen-arm.cc#newcode332 src/arm/codegen-arm.cc:332: // Handle external strings. Any reason for not just having this be fall-through code after the check_sequential branching and then just negating the branch to jump over? It does not seem intuitive to me that this is placed up here (if you move it, please also do so on ia32 and x64) http://codereview.chromium.org/8682010/diff/1001/src/arm/codegen-arm.cc#newcode358 src/arm/codegen-arm.cc:358: // Handle conses. Handle cons strings? http://codereview.chromium.org/8682010/diff/1001/src/arm/codegen-arm.cc#newcode379 src/arm/codegen-arm.cc:379: // the adjusted index to the runtime function. Please fix comment, we don't do this anymore. Please also update this on the other platforms http://codereview.chromium.org/8682010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
