LGTM
http://codereview.chromium.org/8662009/diff/1/src/x64/codegen-x64.cc File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/8662009/diff/1/src/x64/codegen-x64.cc#newcode408 src/x64/codegen-x64.cc:408: __ testb(result, Immediate(kShortExternalStringTag)); kShortExternalStringMask http://codereview.chromium.org/8662009/diff/1/src/x64/codegen-x64.cc#newcode438 src/x64/codegen-x64.cc:438: // Check whether the string is sequential. The only non-sequential Slightly confusing comment. How about something like: "Distinguish sequential and external strings. Only these two string representations can reach here (slices and flat cons strings have been reduced to the underlying sequential or external string)." http://codereview.chromium.org/8662009/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
