I will close this issue but merge the changes into
http://codereview.chromium.org/8590027/ .
Will upload an updated patchset soon.
http://codereview.chromium.org/8585001/diff/4001/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
http://codereview.chromium.org/8585001/diff/4001/src/arm/full-codegen-arm.cc#newcode363
src/arm/full-codegen-arm.cc:363: CodeGenerator::RecordPositions(masm_,
function()->end_position() - 1);
Søren and I came up with a different scheme when debug breaking in the
return sequence. In this case we don't use the source position anymore
to learn about the scopes. We simply return only the function scope but
not any of the inner catch/with/block scopes.
So for the ScopeIterator this hunk is not important anymore. I left it
as it was before and added test cases.
On 2011/11/21 10:16:40, Lasse Reichstein wrote:
What if the function source doesn't have a closing brace, e.g.,
Function("return
42;") ?
Will this still work?
http://codereview.chromium.org/8585001/diff/4001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
http://codereview.chromium.org/8585001/diff/4001/src/ia32/full-codegen-ia32.cc#newcode367
src/ia32/full-codegen-ia32.cc:367:
SetSourcePosition(function()->end_position() - 1);
This is not important anymore. I added special handling of the return
sequence case to the ScopeIterator.
On 2011/11/21 10:16:40, Lasse Reichstein wrote:
Can't the final character coincide with another scope close, e.g.,
"with (x) y = z; "
?
http://codereview.chromium.org/8585001/diff/4001/test/mjsunit/debug-stepout-scope.js
File test/mjsunit/debug-stepout-scope.js (right):
http://codereview.chromium.org/8585001/diff/4001/test/mjsunit/debug-stepout-scope.js#newcode141
test/mjsunit/debug-stepout-scope.js:141: eval("with ({x:1}) x = 1");
On 2011/11/21 10:16:40, Lasse Reichstein wrote:
Try adding tests with an extra character at the end, e.g., a space. Or
a
semicolon followed by a space.
Done.
http://codereview.chromium.org/8585001/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
