LGTM (with nits).
http://codereview.chromium.org/8692002/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/8692002/diff/1/src/mark-compact.cc#newcode421 src/mark-compact.cc:421: int number_of_pages = 0; Can we instead use PagedSpace::CountTotalPages() and make that available for non-debug builds instead? http://codereview.chromium.org/8692002/diff/1/src/mark-compact.cc#newcode432 src/mark-compact.cc:432: const int kMaxMaxEvacuationCandidates = 1000; Why two 'Max' in that constant? http://codereview.chromium.org/8692002/diff/1/src/spaces.h File src/spaces.h (right): http://codereview.chromium.org/8692002/diff/1/src/spaces.h#newcode1573 src/spaces.h:1573: int Fragmentation(Page* p) { A one-liner comment about the possible range of return values would be nice here. http://codereview.chromium.org/8692002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
