The previous checks indeed, subtly, include the kNotStringTag bit in the comparison, and should be safe. If doing it this way, at least put a comment explaining that the lt(r1, ...) comparison can't succeed if the object is a non-string.
Apart from that, the optimal (IMO) place to check for the input being a string
is in the code for %_RegExpExec, not in the stub that it happens to call. In either case, LGTM. http://codereview.chromium.org/8554004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
