LGTM
http://codereview.chromium.org/8680010/diff/3001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/8680010/diff/3001/src/arm/code-stubs-arm.cc#newcode4563 src/arm/code-stubs-arm.cc:4563: __ and_(r1, r0, Operand(kIsNotStringMask | kStringRepresentationMask), SetCC); Could you add kShortStringMask here? That would make r1 have the 0x10 bit set if it's short, just as it has the 0x80 bit set if it's not a string. Any value above kStringRepresentationMask would make it go to runtime (with the test for being not-a-string that was introduced here?) http://codereview.chromium.org/8680010/diff/3001/src/arm/code-stubs-arm.cc#newcode4581 src/arm/code-stubs-arm.cc:4581: This was where you added the is-not-string test, right? http://codereview.chromium.org/8680010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
