Reviewers: Yang,
Message:
Please take a look.
Description:
Fix compile errors on Windows and Mac introduced by r10093.
BUG=
TEST=
Please review this at http://codereview.chromium.org/8746021/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/heap.cc
M test/cctest/test-heap.cc
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index
868ae480016e225050cc26af0be5de6ddf9a8439..f948c6c88f6e5fd85eac6b4c581e184988d3e50d
100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -1086,7 +1086,7 @@ void Heap::Scavenge() {
incremental_marking()->PrepareForScavenge();
- AdvanceSweepers(new_space_.Size());
+ AdvanceSweepers(static_cast<int>(new_space_.Size()));
// Flip the semispaces. After flipping, to space is empty, from space
has
// live objects.
@@ -4559,7 +4559,8 @@ bool Heap::IdleNotification(int hint) {
intptr_t step_size = size_factor *
IncrementalMarking::kAllocatedThreshold;
if (incremental_marking()->IsStopped()) {
- if (!IsSweepingComplete() && !AdvanceSweepers(step_size)) {
+ if (!IsSweepingComplete() &&
+ !AdvanceSweepers(static_cast<int>(step_size))) {
return false;
}
}
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index
3daf81991d2101126c05c0d2cfcd193608660a54..71f9ac5b3f0c987058b568d30d3ceab2d8cd4c73
100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -1313,7 +1313,7 @@ TEST(IdleNotificationAdvancesIncrementalMarking) {
}
intptr_t old_size = HEAP->SizeOfObjects();
bool no_idle_work = v8::V8::IdleNotification();
- while (!v8::V8::IdleNotification());
+ while (!v8::V8::IdleNotification()) ;
intptr_t new_size = HEAP->SizeOfObjects();
CHECK(no_idle_work || new_size < 3 * old_size / 4);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
