Lgtm, but decrease==>increase. On Dec 1, 2011 8:20 AM, <[email protected]> wrote:
> Reviewers: Kevin Millikin, > > Description: > Decrease tick interval for the android platform. > > The phones and tablets currently in use are much slower that desktop > and laptop machines for which the current heuristics have been tuned. > > Please review this at > http://codereview.chromium.**org/8757017/<http://codereview.chromium.org/8757017/> > > SVN Base: > http://v8.googlecode.com/svn/**branches/bleeding_edge/<http://v8.googlecode.com/svn/branches/bleeding_edge/> > > Affected files: > M src/log.h > > > Index: src/log.h > ==============================**==============================**======= > --- src/log.h (revision 10046) > +++ src/log.h (working copy) > @@ -295,7 +295,13 @@ > INLINE(static LogEventsAndTags ToNativeByScript(**LogEventsAndTags, > Script*)); > > // Profiler's sampling interval (in milliseconds). > +#if defined(ANDROID) > + // Phones and tablets have processors that are much slower than desktop > + // and laptop computers for which current heuristics are tuned. > + static const int kSamplingIntervalMs = 5; > +#else > static const int kSamplingIntervalMs = 1; > +#endif > > // Callback from Log, stops profiling in case of insufficient resources. > void LogFailure(); > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
