Scratch what I said about static. I didn't see enough context. On Dec 1, 2011 8:59 AM, "Kevin Millikin" <[email protected]> wrote:
> Lgtm, but no need for static. > On Dec 1, 2011 8:43 AM, <[email protected]> wrote: > >> Reviewers: Kevin Millikin, >> >> Description: >> Merge r10103 to trunk. This increases the tick interval on android. >> >> Please review this at >> http://codereview.chromium.**org/8760026/<http://codereview.chromium.org/8760026/> >> >> SVN Base: >> http://v8.googlecode.com/svn/**trunk/<http://v8.googlecode.com/svn/trunk/> >> >> Affected files: >> M src/log.h >> >> >> Index: src/log.h >> ==============================**==============================**======= >> --- src/log.h (revision 10103) >> +++ src/log.h (working copy) >> @@ -295,7 +295,13 @@ >> INLINE(static LogEventsAndTags ToNativeByScript(**LogEventsAndTags, >> Script*)); >> >> // Profiler's sampling interval (in milliseconds). >> +#if defined(ANDROID) >> + // Phones and tablets have processors that are much slower than desktop >> + // and laptop computers for which current heuristics are tuned. >> + static const int kSamplingIntervalMs = 5; >> +#else >> static const int kSamplingIntervalMs = 1; >> +#endif >> >> // Callback from Log, stops profiling in case of insufficient resources. >> void LogFailure(); >> >> >> -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
