Lgtm.
On Dec 1, 2011 8:44 AM, <[email protected]> wrote:

> Reviewers: Kevin Millikin,
>
> Description:
> Merge r10103 to the 3.6 branch, this increases tick interval on android.
>
> Please review this at 
> http://codereview.chromium.**org/8762022/<http://codereview.chromium.org/8762022/>
>
> SVN Base: 
> http://v8.googlecode.com/svn/**branches/3.6/<http://v8.googlecode.com/svn/branches/3.6/>
>
> Affected files:
>  M     src/log.h
>
>
> Index: src/log.h
> ==============================**==============================**=======
> --- src/log.h   (revision 10103)
> +++ src/log.h   (working copy)
> @@ -294,7 +294,13 @@
>   INLINE(static LogEventsAndTags ToNativeByScript(**LogEventsAndTags,
> Script*));
>
>   // Profiler's sampling interval (in milliseconds).
> +#if defined(ANDROID)
> +  // Phones and tablets have processors that are much slower than desktop
> +  // and laptop computers for which current heuristics are tuned.
> +  static const int kSamplingIntervalMs = 5;
> +#else
>   static const int kSamplingIntervalMs = 1;
> +#endif
>
>   // Callback from Log, stops profiling in case of insufficient resources.
>   void LogFailure();
>
>
>

-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to