This is great! I worked on the previous code for this, and didn't think
that
all the corner cases could be detected, but you do it by testing the status
word
after the log and exp calculations. I don't see where you clear the status
word, before these calculations, though.
http://codereview.chromium.org/8749002/diff/4013/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
http://codereview.chromium.org/8749002/diff/4013/src/ia32/code-stubs-ia32.cc#newcode3078
src/ia32/code-stubs-ia32.cc:3078: __ fnstsw_ax();
Where does the status word get cleared? How do we accumulate exceptions
from just the above code, and not earlier? Do you use the fnclex
instruction?
http://codereview.chromium.org/8749002/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
