Comments addressed, landing.
http://codereview.chromium.org/8747009/diff/4001/src/hydrogen.cc
File src/hydrogen.cc (right):
http://codereview.chromium.org/8747009/diff/4001/src/hydrogen.cc#newcode3467
src/hydrogen.cc:3467: } else {
On 2011/11/30 14:04:51, Jakob wrote:
Since the if-branch ends with a return statement, you can skip the
explicit
"else {" to avoid the "arrow" anti-pattern.
Done.
http://codereview.chromium.org/8747009/diff/4001/src/hydrogen.cc#newcode3504
src/hydrogen.cc:3504: AddInstruction(new(zone()) HStoreKeyedFastElement(
On 2011/11/30 14:04:51, Jakob wrote:
Hm... this will deopt if |value| doesn't match
|boilerplate_elements_kind|, but
IIUC your changes to runtime.cc should make sure that doesn't happen
too often.
OK.
Done.
http://codereview.chromium.org/8747009/diff/4001/test/mjsunit/array-literal-transitions.js
File test/mjsunit/array-literal-transitions.js (right):
http://codereview.chromium.org/8747009/diff/4001/test/mjsunit/array-literal-transitions.js#newcode192
test/mjsunit/array-literal-transitions.js:192: array =
deopt_array_literal_all_doubles(foo);;
On 2011/11/30 14:04:51, Jakob wrote:
nit: duplicate semicolon
Done.
http://codereview.chromium.org/8747009/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
