When you add an instruction to the assembler you should add it to the disassembler and to the disassembler and assembler cctests.
LGTM http://codereview.chromium.org/8769037/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/8769037/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2944 src/ia32/lithium-codegen-ia32.cc:2944: __ push(ecx); This is nasty. We have support for allocating temporary registers in Lithium, so we don't need to push and pop if we have registers. http://codereview.chromium.org/8769037/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
