LGTM (with nits).
http://codereview.chromium.org/8776032/diff/1011/src/store-buffer.cc File src/store-buffer.cc (right): http://codereview.chromium.org/8776032/diff/1011/src/store-buffer.cc#newcode73 src/store-buffer.cc:73: if (initial_length == 0) initial_length = 1; Can we change this into ASSERT(initial_length != 0)? http://codereview.chromium.org/8776032/diff/1011/src/store-buffer.cc#newcode176 src/store-buffer.cc:176: reinterpret_cast<void*>(old_limit_), grow * kPointerSize, false)); Can we put each argument on a separate line like with the two occurences above? http://codereview.chromium.org/8776032/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
