Revision: 10180 Author: [email protected] Date: Tue Dec 6 07:31:01 2011 Log: Remove unnecessary use of raw pointers in hydrogen graph builder.
This is potentially a source of bugs, if someone inserts some code that causes allocation. Review URL: http://codereview.chromium.org/8818015 http://code.google.com/p/v8/source/detail?r=10180 Modified: /branches/bleeding_edge/src/hydrogen.cc ======================================= --- /branches/bleeding_edge/src/hydrogen.cc Tue Dec 6 01:41:06 2011 +++ /branches/bleeding_edge/src/hydrogen.cc Tue Dec 6 07:31:01 2011 @@ -3336,13 +3336,13 @@ int* total_size) { if (max_depth <= 0) return false; - FixedArrayBase* elements = boilerplate->elements(); + Handle<FixedArrayBase> elements(boilerplate->elements()); if (elements->length() > 0 && elements->map() != HEAP->fixed_cow_array_map()) { return false; } - FixedArray* properties = boilerplate->properties(); + Handle<FixedArray> properties(boilerplate->properties()); if (properties->length() > 0) { return false; } else { @@ -3468,7 +3468,7 @@ int length = subexprs->length(); HValue* context = environment()->LookupContext(); - FixedArray* literals = environment()->closure()->literals(); + Handle<FixedArray> literals(environment()->closure()->literals()); Handle<Object> raw_boilerplate(literals->get(expr->literal_index())); // For now, no boilerplate causes a deopt. -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
