LGTM if the comments are addressed.
http://codereview.chromium.org/8821019/diff/10/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/8821019/diff/10/src/ia32/code-stubs-ia32.cc#newcode2978 src/ia32/code-stubs-ia32.cc:2978: Moving the empty line before the bind would be better. http://codereview.chromium.org/8821019/diff/10/src/ia32/code-stubs-ia32.cc#newcode3078 src/ia32/code-stubs-ia32.cc:3078: __ addsd(double_exponent, double_base); // Convert -0 to +0. addsd(double_base, double_exponent) would allow you to use double_base later. http://codereview.chromium.org/8821019/diff/10/src/ia32/code-stubs-ia32.cc#newcode3112 src/ia32/code-stubs-ia32.cc:3112: __ test_b(exponent, 0x5F); // We check for all but precision exception. Assuming that exponent == eax. http://codereview.chromium.org/8821019/diff/10/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/8821019/diff/10/src/x64/code-stubs-x64.cc#newcode2128 src/x64/code-stubs-x64.cc:2128: __ addsd(double_exponent, double_base); // Convert -0 to +0. addsd(double_base, double_exponent) would allow you to use double_base later. http://codereview.chromium.org/8821019/diff/2002/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/8821019/diff/2002/src/ia32/lithium-codegen-ia32.cc#newcode2995 src/ia32/lithium-codegen-ia32.cc:2995: ASSERT(!instr->InputAt(1)->IsDoubleRegister() || Don't forget to change the assertions to reflect register changes. http://codereview.chromium.org/8821019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
