Reviewers: Erik Corry,
Message:
Please take a look.
If a full GC happens during the script execution, there is no guarantee that
idle notifications after the script execution can free more memory.
Description:
Relax test condition to make it less brittle.
BUG=
TEST=cctest/test-api/IdleNotificationWithHint
Please review this at http://codereview.chromium.org/8839007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/cctest/test-api.cc
M test/cctest/test-heap.cc
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index
3f444b3708a833715d383878312928404c338943..5ccf8d2b1a6885bc0b004e216933eca52f8f1715
100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -13488,7 +13488,7 @@ THREADED_TEST(IdleNotificationWithHint) {
}
CHECK(rv == true);
intptr_t new_size = HEAP->SizeOfObjects();
- CHECK(no_idle_work || new_size < 3 * old_size / 4);
+ CHECK(no_idle_work || new_size < old_size);
}
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index
da3ccb9273c0557ac39f6485d521dd166f9aebb0..3f494fb468dece1e80e9fe47f5dcfd1a02c254f7
100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -1315,5 +1315,5 @@ TEST(IdleNotificationAdvancesIncrementalMarking) {
bool no_idle_work = v8::V8::IdleNotification(900);
while (!v8::V8::IdleNotification(900)) ;
intptr_t new_size = HEAP->SizeOfObjects();
- CHECK(no_idle_work || new_size < 3 * old_size / 4);
+ CHECK(no_idle_work || new_size < old_size);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
