LGTM with comments.
http://codereview.chromium.org/8831008/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/8831008/diff/1/src/runtime.cc#newcode7444 src/runtime.cc:7444: } else if (isnan(y) || ((x == 1 || x == -1) && isinf(y))) { This code is almost the same as in power_double_double. Can we reuse it? http://codereview.chromium.org/8831008/diff/1/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/8831008/diff/1/src/x64/code-stubs-x64.cc#newcode2208 src/x64/code-stubs-x64.cc:2208: __ cvtlsi2sd(double_exponent, exponent); Could you please add a comment explaining why we need the instruction? 1) double_exponent is aliased with double_scratch2, so it gets overwritten. 2) double_exponent might not contain the exponent at all if the exponent is SMI. http://codereview.chromium.org/8831008/diff/1/src/x64/code-stubs-x64.cc#newcode2234 src/x64/code-stubs-x64.cc:2234: }; Redundant semicolon. http://codereview.chromium.org/8831008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
