Lgtm. There was also an issue number (maybe chromium) for the parser fix. You might quote that or just mention that this is a bug fix. On Dec 8, 2011 1:47 PM, <[email protected]> wrote:
> Reviewers: Kevin Millikin, > > Description: > Prepare push to trunk. Now working on version 3.8.1. > > Please review this at > http://codereview.chromium.**org/8873016/<http://codereview.chromium.org/8873016/> > > SVN Base: > http://v8.googlecode.com/svn/**branches/bleeding_edge/<http://v8.googlecode.com/svn/branches/bleeding_edge/> > > Affected files: > M ChangeLog > M src/version.cc > > > Index: ChangeLog > ==============================**==============================**======= > --- ChangeLog (revision 10212) > +++ ChangeLog (working copy) > @@ -1,3 +1,12 @@ > +2011-12-8: Version 3.8.0 > + > + Fixed handling of arrays in DefineOwnProperty. (issue 1756) > + > + Sync parser and preparser on do-while and return statements. > + > + Stability and performance improvements on all platforms. > + > + > 2011-12-01: Version 3.7.12 > > Increase tick interval for the android platform. > Index: src/version.cc > ==============================**==============================**======= > --- src/version.cc (revision 10212) > +++ src/version.cc (working copy) > @@ -34,7 +34,7 @@ > // cannot be changed without changing the SCons build script. > #define MAJOR_VERSION 3 > #define MINOR_VERSION 8 > -#define BUILD_NUMBER 0 > +#define BUILD_NUMBER 1 > #define PATCH_LEVEL 0 > // Use 1 for candidates and 0 otherwise. > // (Boolean macro values are not supported by all preprocessors.) > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
