lgtm
http://codereview.chromium.org/8889012/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/8889012/diff/1/src/ia32/code-stubs-ia32.cc#newcode6102 src/ia32/code-stubs-ia32.cc:6102: __ cmp(ecx, 2); Nit: could avoid the SmiUntag here and SmiTag later and just compare to Smi::FromInt(2) directly here, and load Smi::FromInt(2) in line 6131, and cmp to Smi::FromInt(SlicedString::kMinLength) in line 6182. http://codereview.chromium.org/8889012/diff/1/src/ia32/code-stubs-ia32.cc#newcode6151 src/ia32/code-stubs-ia32.cc:6151: // Cons string. Check whether it is flat, then fetch first part. Nit: Maybe add comment about the flat cons invariant. http://codereview.chromium.org/8889012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
