LGTM with one more comment:
http://codereview.chromium.org/8820015/diff/5001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/8820015/diff/5001/src/hydrogen-instructions.h#newcode3510 src/hydrogen-instructions.h:3510: : slot_index_(var->index()) { I'm not convinced that two constructors are better here: I'd rather see at the call-site which mode is used (with or without hole-check) instead of distributing the logic into different files. http://codereview.chromium.org/8820015/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
