http://codereview.chromium.org/8872060/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/8872060/diff/1/src/arm/code-stubs-arm.cc#newcode6740
src/arm/code-stubs-arm.cc:6740: __ Push(r1, r0);
On 2011/12/09 09:10:31, Kevin Millikin wrote:
You could move this (and the corresponding pops) to use the internal
frame
instead of using the caller's frame.
Done.
http://codereview.chromium.org/8872060/diff/1/src/ic.cc
File src/ic.cc (right):
http://codereview.chromium.org/8872060/diff/1/src/ic.cc#newcode2369
src/ic.cc:2369: UNREACHABLE();
On 2011/12/09 09:10:31, Kevin Millikin wrote:
I'd rather have this outside the switch:
switch (state) {
case ... // Cases for all enum values.
}
UNREACHABLE();
return NULL;
Done.
http://codereview.chromium.org/8872060/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
