Almost there - there is a conflicting change, so you'll need some
adjustments in
your code now. Otherwise looks good.
http://codereview.chromium.org/8857001/diff/12001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
http://codereview.chromium.org/8857001/diff/12001/src/hydrogen-instructions.h#newcode3452
src/hydrogen-instructions.h:3452: kIsHoleCheck
Please rebase your change. It seems to conflict with r10220 which also
introduces harmony-related changes (handling CONST_HARMONY etc.).
Basically you need to change this to have 3 modes here. (no check,
const-harmony hole-check (deoptimizes) and const hole-check (returns
undefined).
The HStoreContextSlow will also need to be changed accordingly.
http://codereview.chromium.org/8857001/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
