Thanks for the comments; I ended up simplifying this quite a bit. Please
take
another quick look.
http://codereview.chromium.org/8898021/diff/1/src/d8.cc
File src/d8.cc (right):
http://codereview.chromium.org/8898021/diff/1/src/d8.cc#newcode299
src/d8.cc:299: if (args[0]->IsUint32()) {
On 2011/12/13 11:28:39, Rico wrote:
Below: How about just having a local TryCatch? The functionality in
isolate.cc
should throw to the TryCatch nearest to the top of the stack
Done.
http://codereview.chromium.org/8898021/diff/1/src/d8.cc#newcode316
src/d8.cc:316: return ThrowException(String::New("Array length must be a
number."));
On 2011/12/13 11:28:39, Rico wrote:
we already established that length is a number, so this exception
seems wrong.
Can we ever end up here?
On second thought, no, we can't. Done.
http://codereview.chromium.org/8898021/diff/1/test/mjsunit/regress/regress-crbug-100859.js
File test/mjsunit/regress/regress-crbug-100859.js (right):
http://codereview.chromium.org/8898021/diff/1/test/mjsunit/regress/regress-crbug-100859.js#newcode33
test/mjsunit/regress/regress-crbug-100859.js:33: exception = false;
On 2011/12/13 11:28:39, Rico wrote:
var exeception
Done. Copy-paste-error.
http://codereview.chromium.org/8898021/diff/1/test/mjsunit/regress/regress-crbug-100859.js#newcode41
test/mjsunit/regress/regress-crbug-100859.js:41: assertTrue(exception);
On 2011/12/13 11:28:39, Rico wrote:
we don't really need this: exception=false => we should have hit
assertUnreachable
Right. Done.
http://codereview.chromium.org/8898021/diff/1/test/mjsunit/regress/regress-crbug-100859.js#newcode48
test/mjsunit/regress/regress-crbug-100859.js:48: var exception = false;
On 2011/12/13 11:28:39, Rico wrote:
not var
Done.
http://codereview.chromium.org/8898021/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
