lgtm
http://codereview.chromium.org/8996008/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/8996008/diff/1/src/runtime.cc#newcode4333 src/runtime.cc:4333: // in defineProperty. Firefox disagrees here, and actually changes the value. 80 characters http://codereview.chromium.org/8996008/diff/1/src/runtime.cc#newcode4346 src/runtime.cc:4346: kNonStrictMode); This should be KStrictMode, I think. http://codereview.chromium.org/8996008/diff/1/test/mjsunit/regress/regress-1530.js File test/mjsunit/regress/regress-1530.js (right): http://codereview.chromium.org/8996008/diff/1/test/mjsunit/regress/regress-1530.js#newcode28 test/mjsunit/regress/regress-1530.js:28: // Test that redefining the 'prototype' property of a function object Maybe test other magic properties of functions, too? http://codereview.chromium.org/8996008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
