LGTM with the comment addressed.
http://codereview.chromium.org/9018013/diff/1/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): http://codereview.chromium.org/9018013/diff/1/tools/gyp/v8.gyp#newcode224 tools/gyp/v8.gyp:224: 'optimize': 'max', That needs to be 'variables': { 'optimize': 'max', }, http://codereview.chromium.org/9018013/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
