lgtm



http://codereview.chromium.org/9021019/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/9021019/diff/1/test/cctest/test-api.cc#newcode1443
test/cctest/test-api.cc:1443:
THREADED_TEST(SwitchFromAccessorToInterceptor) {
Not your change, but could you add a variant of this test not using
inheritance, analogous to your new one below?

http://codereview.chromium.org/9021019/diff/1/test/cctest/test-api.cc#newcode1464
test/cctest/test-api.cc:1464: Handle<FunctionTemplate> child =
FunctionTemplate::New();
"child"? Where is the parent? ;)

http://codereview.chromium.org/9021019/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to