Thanks! I will land and backport.
http://codereview.chromium.org/8960004/diff/1/src/ia32/lithium-codegen-ia32.h File src/ia32/lithium-codegen-ia32.h (right): http://codereview.chromium.org/8960004/diff/1/src/ia32/lithium-codegen-ia32.h#newcode84 src/ia32/lithium-codegen-ia32.h:84: return Immediate(ToInteger32(LConstantOperand::cast(op))); On 2011/12/23 09:09:23, danno wrote:
::cast is redundant?
I don't think so, ToInteger takes LConstantOperand*, ToInteger32Immediate LOperand* (I introduced this helper only to avoid writing this cast everywhere) http://codereview.chromium.org/8960004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
