LGTM with comments addressed.
http://codereview.chromium.org/8968028/diff/2001/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/8968028/diff/2001/src/objects.cc#newcode9253 src/objects.cc:9253: if (has_smi_only_elements) { I think you need an additional "&& FLAG_smi_only_arrays" here, otherwise it'll transition to SMI elements even if the flag is off. http://codereview.chromium.org/8968028/diff/2001/test/mjsunit/regress/regress-1849.js File test/mjsunit/regress/regress-1849.js (right): http://codereview.chromium.org/8968028/diff/2001/test/mjsunit/regress/regress-1849.js#newcode1 test/mjsunit/regress/regress-1849.js:1: // Copyright 2009 the V8 project authors. All rights reserved. 2011 http://codereview.chromium.org/8968028/diff/2001/test/mjsunit/regress/regress-1849.js#newcode30 test/mjsunit/regress/regress-1849.js:30: // Flags: --allow-natives-syntax --smi-only-arrays ? And then you'll need to put the assertion behind an if() that checks if the flag is in effect. http://codereview.chromium.org/8968028/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
