I was thinking the same. I'll work on that as next step. This CL was pretty small and also a proof of concept that there is actually a performance gain here.
-Yang On Tue, Jan 3, 2012 at 10:57 AM, Florian Schneider <[email protected]>wrote: > This change is OK, but maybe even made obsolete, if we generate a > specialized Math.min/max in hydrogen (similar to the other Math.* > functions). > > > Den 3. jan. 2012 10.52 skrev <[email protected]>: > > LGTM. >> >> >> >> http://codereview.chromium.**org/9065008/diff/1/src/math.js<http://codereview.chromium.org/9065008/diff/1/src/math.js> >> File src/math.js (right): >> >> http://codereview.chromium.**org/9065008/diff/1/src/math.**js#newcode127<http://codereview.chromium.org/9065008/diff/1/src/math.js#newcode127> >> src/math.js:127: if (arg1 == arg2) { >> It does not make a difference for numbers, but I'd consistently use >> either === or ==. >> >> http://codereview.chromium.**org/9065008/<http://codereview.chromium.org/9065008/> >> > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
