Reviewers: Kevin Millikin, Message: Please take a look.
This CL is the first in series of changes that convert handlified global functions to static methods of the corresponding classes. http://codereview.chromium.org/9008012/diff/1/src/handles.h File src/handles.h (left): http://codereview.chromium.org/9008012/diff/1/src/handles.h#oldcode169 src/handles.h:169: The functions below are moved to the following classes: Object: GetPrototype JSReceiver: SetProperty JSObject: GetIdentityHash DeleteElement DeleteProperty NormalizeElements NormalizeProperties PreventExtensions SetElement SetHiddenProperty SetNormalizedProperty SetLocalPropertyIgnoreAttributes SetLocalPropertyNoThrow SetOwnElement TransformToFastProperties TransitionElementsKind NumberDictionary: Set http://codereview.chromium.org/9008012/diff/1/src/handles.h#oldcode261 src/handles.h:261: int GetIdentityHash(Handle<JSReceiver> obj); Made it static method of JSObject, not JSReceiver. Because the only user (v8::Object::GetIdentityHash) of this function passes JSObject as an argument and JSReceiver::GetIdentityHash invokes JSObject::GetIdentityHash in this case. http://codereview.chromium.org/9008012/diff/1/src/objects.cc File src/objects.cc (left): http://codereview.chromium.org/9008012/diff/1/src/objects.cc#oldcode3870 src/objects.cc:3870: MaybeObject* JSReceiver::DeleteProperty(String* name, DeleteMode mode) { Placed JSReceiver::DeleteProperty and JSReceiver::DeleteElement after JSObject::DeleteProperty (line 4034) http://codereview.chromium.org/9008012/diff/1/src/runtime.cc File src/runtime.cc (left): http://codereview.chromium.org/9008012/diff/1/src/runtime.cc#oldcode5141 src/runtime.cc:5141: if (ok->IsRetryAfterGC()) return ok; Changed it to a handlified function call. Is this correct? Description: Move handlified functions from handles.cc to objects.cc BUG= TEST= Please review this at http://codereview.chromium.org/9008012/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/api.cc M src/bootstrapper.cc M src/debug.cc M src/factory.cc M src/handles.h M src/handles.cc M src/ic.cc M src/isolate.cc M src/json-parser.h M src/liveedit.cc M src/objects.h M src/objects.cc M src/runtime.cc M src/stub-cache.cc M test/cctest/test-api.cc -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
