Reviewers: ulan,
Message:
PTAL. snprintf doesnt exist on windows.
Description:
Fix windows build.
Please review this at http://codereview.chromium.org/8983014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/cctest/test-api.cc
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index
c48a521969e56991cd4126cbc3454803da3ebaad..9baa56bbe6725ab52beffcc310ffce3d18d4d20c
100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -15732,13 +15732,13 @@ uint8_t callback_fired = 0;
void CallCompletedCallback1() {
- printf("Firing callback 1.\n");
+ i::OS::Print("Firing callback 1.\n");
callback_fired ^= 1; // Toggle first bit.
}
void CallCompletedCallback2() {
- printf("Firing callback 2.\n");
+ i::OS::Print("Firing callback 2.\n");
callback_fired ^= 2; // Toggle second bit.
}
@@ -15747,14 +15747,15 @@ Handle<Value> RecursiveCall(const Arguments&
args) {
uint32_t level = args[0]->Uint32Value();
if (level < 3) {
level++;
- printf("Entering recursion level %d.\n", level);
+ i::OS::Print("Entering recursion level %d.\n", level);
char script[64];
- snprintf(script, sizeof(script), "recursion(%d)", level);
- CompileRun(script);
- printf("Leaving recursion level %d.\n", level);
+ i::Vector<char> script_vector(script, sizeof(script));
+ i::OS::SNPrintF(script_vector, "recursion(%d)", level);
+ CompileRun(script_vector.start());
+ i::OS::Print("Leaving recursion level %d.\n", level);
CHECK_EQ(0, callback_fired);
} else {
- printf("Recursion ends.\n");
+ i::OS::Print("Recursion ends.\n");
CHECK_EQ(0, callback_fired);
}
return Undefined();
@@ -15772,19 +15773,19 @@ TEST(CallCompletedCallback) {
v8::V8::AddCallCompletedCallback(CallCompletedCallback1);
v8::V8::AddCallCompletedCallback(CallCompletedCallback1);
v8::V8::AddCallCompletedCallback(CallCompletedCallback2);
- printf("--- Script (1) ---\n");
+ i::OS::Print("--- Script (1) ---\n");
Local<Script> script =
v8::Script::Compile(v8::String::New("recursion(0)"));
script->Run();
CHECK_EQ(3, callback_fired);
- printf("\n--- Script (2) ---\n");
+ i::OS::Print("\n--- Script (2) ---\n");
callback_fired = 0;
v8::V8::RemoveCallCompletedCallback(CallCompletedCallback1);
script->Run();
CHECK_EQ(2, callback_fired);
- printf("\n--- Function ---\n");
+ i::OS::Print("\n--- Function ---\n");
callback_fired = 0;
Local<Function> recursive_function =
Local<Function>::Cast(env->Global()->Get(v8_str("recursion")));
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
